Skip to content

feat: Add ChannelKeeperV2 to IBC Keeper initialization #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leopardracer
Copy link

This PR updates the IBC Keeper initialization to include ChannelKeeperV2 in the sovereign app. The change adds support for the new IBC channel keeper version while maintaining compatibility with the existing channel keeper implementation.

Changes:

  • Added ChannelKeeperV2 to the TransferKeeper initialization
  • Updated the IBC Keeper dependencies to include both channel keeper versions
  • Maintains backwards compatibility with existing IBC channel functionality

This enhancement allows for improved IBC channel management capabilities while ensuring smooth integration with the existing IBC infrastructure.

@leopardracer leopardracer requested a review from a team March 5, 2025 08:26
@github-actions github-actions bot added the C:Testing Assigned automatically by the PR labeler label Mar 5, 2025
@leopardracer
Copy link
Author

Hi, @vladjdk! Please check this PR whenever you have a free moment.

@vladjdk
Copy link
Member

vladjdk commented Mar 24, 2025

Hi @leopardracer, tests are failing. Seems like the v2 stack isn't being initialized properly. Please refer to Gaia for a reference on how to add the stack: https://github.com/cosmos/gaia/blob/a1998b835eee371781a53fcdc911d05ee76e257c/app/keepers/keepers.go#L553

@leopardracer
Copy link
Author

@vladjdk Hi! Just wanted to remind you about this PR. If you have some time, please take a look. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Testing Assigned automatically by the PR labeler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants